Skip to content

834: module name declaration inspection flags valid code #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 24, 2021
Merged

834: module name declaration inspection flags valid code #898

merged 4 commits into from
Dec 24, 2021

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

Fixed module name declaration inspection flags valid code.

Issue was reproduced before fixing it:

Screenshot 2021-12-24 at 10 15 19

Result:

Screenshot 2021-12-24 at 10 15 07

Fixed Issues (if relevant)

  1. Fixes Module name declaration inspection flags valid code #834

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk linked an issue Dec 24, 2021 that may be closed by this pull request
Module name declaration inspection flags valid code #834
Closed
andrewbess
andrewbess approved these changes Dec 24, 2021
View reviewed changes
Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution
Approved ✔️

@andrewbess andrewbess merged commit 6607841 into magento:4.2.2-develop Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

Assignees

@andrewbess andrewbess

Labels
Easy Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module name declaration inspection flags valid code
2 participants
@bohdan-harniuk @andrewbess